On 8/9/2018 1:17 PM, Sean Mullan wrote:
A few (mostly minor) comments on the Solution section. I'll continue
my review of the rest of the CSR later.
First sentence, "from the existing API ECDSA ..." should that be "API
for ECDSA"?
// example: use KeyFactory to contruct a public key
typo: construct
Thanks. I fixed these typos.
"This API does not standardize "EdEC" algorithm names, so the
programmer must use "EdDSA" as the algorithm name to obtain a
KeyPairGenerator or KeyFactory."
In the example, you use "Ed25519" and not "ECDSA" as the alg name for
KeyPairGenerator - which one is correct?
I added a parenthetical to clarify that "Ed25519" can be used here in
addition to "EdDSA". The point of this sentence is to state that there
is no algorithm name like "EdEC" that can be used generate keys for
either EdDSA or some other scheme that uses the same kind of keys.
--Sean
