Thanks Max for review, corrected all the coding style changes. Thanks, Prasad.K
-----Original Message----- From: Weijun Wang Sent: Wednesday, September 19, 2018 9:09 PM To: Prasadrao Koppula <prasadarao.kopp...@oracle.com> Cc: security-dev@openjdk.java.net Subject: Re: [8u-dev] RFR JDK-8187218 & JDK-8131051, two krb5 fixes on renewable Change looks fine, but the code style of lines 947-954 is quite different from normal, including, no space after keywords, wrong indentation of inner block and wrapped line, brace and else not on the same line, etc. --Max > On Sep 19, 2018, at 10:40 PM, Prasadrao Koppula > <prasadarao.kopp...@oracle.com> wrote: > > Could you please review the following fixes for 8u-dev? > > jbs: https://bugs.openjdk.java.net/browse/JDK-8187218, > https://bugs.openjdk.java.net/browse/JDK-8131051 > webrev: http://cr.openjdk.java.net/~pkoppula/8187218/webrev.00/ > > Thanks, > Prasad.K
