Hi Andrew, Thanks for having a look at this.
Webrev.02 without "All rights reserved" and "affiliates" parts: * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.02/ * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.02.zip Are you okay to go? Kind regards, Martin.- On Thu, Nov 1, 2018 at 8:12 AM, Andrew Hughes <gnu.and...@redhat.com> wrote: > On Tue, 30 Oct 2018 at 18:00, Martin Balao <mba...@redhat.com> wrote: > > > > Hi, > > > > You're right, this is not relevant for a test. > > > > * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.01 > > * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/ > 8213154.webrev.01.zip > > > > Thanks, > > Martin.- > > > > On Tue, Oct 30, 2018 at 2:50 PM, Alan Bateman <alan.bate...@oracle.com> > wrote: > >> > >> On 30/10/2018 17:44, Martin Balao wrote: > >> > >> Hi, > >> > >> Can I have a review for JDK-8213154 [1]? > >> > >> * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/ > 8213154.webrev.00/ > >> * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/ > 8213154.webrev.00.zip > >> > >> Did you mean to include a test in this update? Just asking because > tests doesn't usually have the Classpath exception. > >> > >> -Alan > > > > > > Classpath exception addition looks fine and appropriate for the JDK > code. The "All rights reserved" additions are unnecessary for RH > copyrights. > -- > Andrew :) > > Senior Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Web Site: http://fuseyism.com > Twitter: https://twitter.com/gnu_andrew_java > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 >
