Hi Dean,

typo AccessController line788: "annocations"

The implementations of

doPrivileged(PrivilegedExceptionAction<T> action) and
doPrivileged(PrivilegedAction<T> action)

Could be a bit more similar since except for the exception wrapping they are the same.

309 return executePrivileged(action, null, Reflection.getCallerClass()); vs. AccessControlContext context = null;
548 Class <?> caller = Reflection.getCallerClass();
549 try {
550 return executePrivileged(action, context, caller);

The context and caller locals aren't needed.

Thanks, Roger

On 11/03/2018 04:00 PM, dean.l...@oracle.com wrote:
I made a pass at improving the comments based on feedback I've received.  I updated webrev.4 in place, along with an incremental diff:

http://cr.openjdk.java.net/~dlong/8212605/webrev.4.update/

dl

On 10/31/18 9:39 PM, Bernd Eckenfels wrote:
I find the tail call optimization comment in wrapException adds only confusion to an otherwise clear helper. But maybe it’s just me who does not understand it.


Reply via email to