Hi Xuelei,

The fix looks fine to me.  I think it would be good to have an else branch off of the check on line 205 so any < 0 value has a warning log entry stating that an invalid value was detected and the cache is getting set to DEFAULT_MAX_CACHE_SIZE.

--Jamil

On 11/14/2018 8:59 AM, Xuelei Fan wrote:
Hi,

Please review this simple update:
    http://cr.openjdk.java.net/~xuelei/8210985/webrev.00/

The default value for the maximum number of entries in the SSL session cache (SSLSessionContext.getSessionCacheSize()) is infinite now.  In the request, the default value is updated to 20480 for performance consideration.

For the detailed behavior update, please refer to CSR:
    https://bugs.openjdk.java.net/browse/JDK-8213577

Thanks,
Xuelei

Reply via email to