Hi Bernd, I agree to both of your comments and will update my code with the changes.
Thanks, Smita From: Bernd Eckenfels [mailto:[email protected]] Sent: Monday, November 19, 2018 2:27 PM To: Kamath, Smita <[email protected]>; 'Vladimir Kozlov' <[email protected]> Cc: [email protected]; [email protected] Subject: Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions Hello, What is the purpose of setting some of them to 0 twice? (It's a new array which should be all-0 anyway.) + for (int i = 1; i < 9 ; i++) { + subkeyHtbl[2*i] = 0; + subkeyHtbl[2*i+1] = 0; + } Also, is the subkeyH no longer be needed (or can be redesigned to use subkeyHtbl[0] and 1? Gruss Bernd -- http://bernd.eckenfels.net ________________________________ Von: core-libs-dev <[email protected]<mailto:[email protected]>> im Auftrag von Kamath, Smita <[email protected]<mailto:[email protected]>> Gesendet: Montag, November 19, 2018 10:52 PM An: 'Vladimir Kozlov' Cc: Anthony Scarpino; [email protected]<mailto:[email protected]>; hotspot compiler Betreff: RFR(S)JDK-8214074: Ghash optimization using AVX instructions Hi Vladimir, I'd like to contribute an optimization for GHASH Algorithm using AVX Instructions. I have tested this optimization on SKX x86_64 platform and it shows ~20-30% performance improvement for larger message sizes (for example 8k). I, [email protected]<mailto:[email protected]<mailto:[email protected]%3cmailto:[email protected]>> , Shay Gueuron, ([email protected]<mailto:[email protected]<mailto:[email protected]%3cmailto:[email protected]>>) and Regev Shemy ([email protected]<mailto:[email protected]<mailto:[email protected]%3cmailto:[email protected]>>) are contributors to this code. Link to Bug: https://bugs.openjdk.java.net/browse/JDK-8214074 Link to webrev: http://cr.openjdk.java.net/~svkamath/ghash/webrev/ For testing the implementation, I have executed TestAESMain.java. I have executed Jtreg tests and tested this code on 64 bit Windows and Linux platforms. Please review and let me know if you have any comments. Thanks and Regards, Smita
