On 1/15/19 7:05 PM, Sean Mullan wrote: > On 1/15/19 11:20 AM, Sean Mullan wrote: > Just "noreg" is not specific enough. You need to add one of the > noreg-<reason> labels as documented in the JDK Developer's Guide [1] > (see step 6). This is kind of a unique case, so I would add noreg-other > and then add a comment explaining that existing tests passing on Solaris > Sparc ensure that this workaround is working. >
Label changed, comment added. > > Sorry for the delay. The tests finished. It looks good. There was one > failure in tools/launcher/Test7029048.java, but this is a known issue: > https://bugs.openjdk.java.net/browse/JDK-8216532 > > So you should be good to push. > http://hg.openjdk.java.net/jdk/jdk/rev/142b179dd60e Thanks, Martin.-
