Adding security-dev as reviews should happen on the corresponding area lists. Even for 8.
On Mon, 2019-03-11 at 07:50 +0000, Andrew John Hughes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8175120 > Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8175120/webrev.01/ This looks OK to me. It removes the same tests as was done for JDK 9. I've verified that KdcPolicy.java passes after your changes. Not a Reviewer, though. Thanks, Severin > Original review: > https://mail.openjdk.java.net/pipermail/security-dev/2017-February/015625.html > > This is not a clean backport because the tests in 8u differ slightly > from those in OpenJDK 10: > > 1. 8u has "JDK-8190690: Impact on krb5 test cases in the 8u nightly". > That same change (adding a property to the @run line) also needs to be > applied to the new KdcPolicy.java test for it to succeed. > > 2. 10u contains "JDK-8006690: sun/security/krb5/auto/BadKdc* tests fails > intermittently" which I assume is obsoleted by the more reliable > KdcPolicy.java test > > Strangely enough, this & JDK-8164656 were already approved last July, > but never pushed [0]. I can't see how this was a straightforward > backport then though either. > > [0] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-July/007667.html
