On 03/04/2019 19:40, Xuelei Fan wrote:
Updated webrev (updated SSLContext.java, HttpsClient, HttpsURLConnectionImpl):
   http://cr.openjdk.java.net/~xuelei/8221882/webrev.01/

This looks good to me, the only change that I'm not 100% sure on is in HttpsClient where the locking will not be consistent with the locking in the HttpClient super class. Would you mind doubling checking that one? We do need to change the HTTP protocol handler so I expect HttpClient will change but it may have to add a protected lock that HttpsClient uses to ensure that they are using the same lock.

As we are already here, I would like to make the improvement for SSLContext. I believe there are also some other improvement we could do.  I make more evaluation later.
Thanks.

-Alan

Reply via email to