On 5/5/19 12:53 AM, Weijun Wang wrote:
Hi Sean,
Please take a review at
https://cr.openjdk.java.net/~weijun/8219013/webrev.00/
Most of the changes are around 1) ECKeyValue 2) new BASE64 methods 3)
XMLUtils.getFullTextChildrenFromNode. There are also quite a bunch of changes
only including year and an apache-style $Id (Ex: DOMHMACSignatureMethod.java)
because the previous JDK-8217878 fix had not updated the year.
Looks good to me.
What kind of noreg label I should choose? I am thinking of noreg-other with an
explanation that this is a sync with upstream repo.
noreg-other with an explanation sounds right to me.
--Sean
