Also the `is*` prefix would point to a boolean, that’s maybe a cleaner data type than a case sensitive string?
-- http://bernd.eckenfels.net ________________________________ Von: security-dev <security-dev-boun...@openjdk.java.net> im Auftrag von Xuelei Fan <xuelei....@oracle.com> Gesendet: Montag, Juli 1, 2019 6:44 PM An: security-dev@openjdk.java.net Betreff: Request for Review [14] JDK-8226976, SessionTimeOutTests uses == operator for String value check Hi, In the following test case, "==" is used to compare two strings. As is not a comment coding convention. I would like to use "equals()" method instead. Thanks, Xuelei $ hg diff test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java diff -r 73f1c84ca264 test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java --- a/test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java Thu Jun 27 22:03:19 2019 +0200 +++ b/test/jdk/javax/net/ssl/SSLSession/SessionTimeOutTests.java Mon Jul 01 09:29:23 2019 -0700 @@ -283,7 +283,7 @@ } System.out.print(sess + " " + lifetime); if (((timeout == 0) || (lifetime < timeout)) && - (isTimedout == "YES")) { + isTimedout.equals("YES")) { isTimedout = "Invalidated before timeout"; }
