Anyone have spare cycles for reviewing this?

The current PKCS11 JNI code for handling native mechanism and its parameters is a bit too all over the place. To make the tracing and verification easier, I consolidated the memory deallocation to the freeCKMechanismPtr(...) method in p11_util.c (some was in p11_keymgmt.c).

Also, fixed the j_XXX_ToCK_XXXX_ methods in p11_convert.c to allocate the memory inside each method and return NULL upon error and make sure allocated memories are free'd upon any failure.

Bug: https://bugs.openjdk.java.net/browse/JDK-8228835

Webrev: http://cr.openjdk.java.net/~valeriep/8228835/webrev.00/

Mach5 run is clean.

Thanks,
Valerie

Reply via email to