Hi Chris!
On 10/3/19 8:05 AM, Chris Hegarty wrote:
Ivan,
On 3 Oct 2019, at 04:41, Ivan Gerasimov <ivan.gerasi...@oracle.com> wrote:
...
So, I filed CSR: https://bugs.openjdk.java.net/browse/JDK-8231805 to cover the
addition of @throws paragraph in the javadoc of SocketPermission.
I would really appreciate it, if someone helped to review it.
Since we’re here ... ;-)
It would be good to specify the NPE behavior of the constructor. Here are the
changes for SocketPermission. If you agree, fold them into your patch and CSR.
( I’ve included test changes to verify the new tighter spec )
https://cr.openjdk.java.net/~chegar/8230407.extra/
Yes, it's a good point, thanks!
I've adopted your suggested changes and the test:
http://cr.openjdk.java.net/~igerasim/8230407/02/webrev/
CSR was also updated accordingly:
https://bugs.openjdk.java.net/browse/JDK-8231805
With kind regards,
Ivan
-Chris.
--
With kind regards,
Ivan Gerasimov
