I added my name as a CSR reviewer and your code change looks fine. One nit, if it were me, I would throw an exception in "CLIENT" mode and let executeCommand() to test for .shouldHaveExitValue(0). It's up to you to decide which is better.
Thanks, Max > On Nov 8, 2019, at 11:24 PM, Martin Balao <mba...@redhat.com> wrote: > > Hi Max, > > Thanks for having a look at this. > > Webrev.02: > > * http://cr.openjdk.java.net/~mbalao/webrevs/8233404/8233404.webrev.02/ > > New in Webrev.02: > > * java.security documentation extended to describe the relationship > with the system property > > * IterationCount test extended to verify that a system property > overrides the security equivalent > > Are we good to go? In case we are, I'll move the CSR to Finalized and push. > > Thanks, > Martin.- >
