Looks fine to me.--Jamil
-------- Original message --------From: Xuelei Fan <xuelei....@oracle.com> 
Date: 12/2/19  7:36 AM  (GMT-08:00) To: security-dev@openjdk.java.net Subject: 
RFR [14] JDK-8235183, Remove the "HACK CODE" in comment Hi,Could I get the 
following update reviewed?    
http://cr.openjdk.java.net/~xuelei/8235183/webrev.00/There are some comments in 
the SunJSSE implementation that come with "HACK CODE". Which are not really bad 
code. They are just used to mark unusual scenarios in case the block get 
removed in the future. However, "HACK" may have negative impression for some 
code readers. It would be nice to remove the "HACK CODE" and use some other 
words to mark the unusual scenarios.Thanks,Xuelei

Reply via email to