Hi Sean,
allowSmartActionArgs has been added quite recently to jtreg by
CODETOOLS-7902352[1], it is a jtreg feature which replaces ${X} in jtreg
actions (such as @run) with the value of X where X is either a "test" system
property[2] or a name from @requires context[3].
[1] https://bugs.openjdk.java.net/browse/CODETOOLS-7902352
[2]
https://hg.openjdk.java.net/code-tools/jtreg/raw-file/90e9eef3d433/src/share/doc/javatest/regtest/tag-spec.html#testvars
[3]
https://hg.openjdk.java.net/code-tools/jtreg/raw-file/90e9eef3d433/src/share/doc/javatest/regtest/tag-spec.html#requires_names
Thanks,
-- Igor
> On Jan 14, 2020, at 2:17 PM, Sean Mullan <[email protected]> wrote:
>
> dropping core-libs-dev and hotspot-dev
>
> On 1/14/20 12:03 PM, Igor Ignatyev wrote:
>> Joe and Roger, thank you for your reviews.
>> security-libs guys, could you please take a look?
>
> Sure, but what is allowSmartActionArgs? I'm assuming this is a jtreg feature
> but I have not heard of it before.
>
> Thanks,
> Sean
>
>
>> Thanks,
>> -- Igor
>>> On Jan 2, 2020, at 12:58 PM, Roger Riggs <[email protected]> wrote:
>>>
>>> The core lib changes look ok.
>>>
>>> Roger
>>> On Jan 2, 2020, at 1:26 PM, Joe Darcy <[email protected]> wrote:
>>>
>>> The removal of the existing TEST.properties files look fine.
>>>
>>> Please also solicit feedback from the security libs team as their area is
>>> affected.
>>>
>>> Roger, FYI the serial filter tests are updated as part of this changeset.
>>>
>>> Cheers,
>>>
>>> -Joe
>>>
>>> On 12/23/2019 8:13 PM, Igor Ignatyev wrote:
>>>> Thanks David.
>>>>
>>>> core-libs folks, could you please review jdk part of this patch?
>>>>
>>>> Thanks,
>>>> -- Igor
>>>>
>>>>> On Dec 23, 2019, at 1:33 PM, David Holmes <[email protected]> wrote:
>>>>>
>>>>> Hi Igor,
>>>>>
>>>>> Hotspot changes seem fine. Can't comment on jdk tests.
>>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>> On 24/12/2019 6:42 am, Igor Ignatyev wrote:
>>>>>> ping?
>>>>>>> On Dec 17, 2019, at 11:30 AM, Igor Ignatyev <[email protected]>
>>>>>>> wrote:
>>>>>>>
>>>>>>> http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/
>>>>>>>> 31 lines changed: 20 ins; 11 del; 0 mod;
>>>>>>> Hi all,
>>>>>>>
>>>>>>> could you please review this small patch which enables
>>>>>>> allowSmartActionArgs in hotspot and jdk test suites and disables them
>>>>>>> in a small number of test directories? the patch also removes
>>>>>>> TEST.properties files which enabled allowSmartActionArgs as they aren't
>>>>>>> needed anymore.
>>>>>>>
>>>>>>> from JBS:
>>>>>>>> currently, allowSmartActionArgs is disabled for the whole hotspot and
>>>>>>>> jdk test suites and enabled just in few places. this makes it a bit
>>>>>>>> harder for people to use smart action arguments in these test suites
>>>>>>>> as they have to not to forget to enable them. and given in all the
>>>>>>>> other test suites, smart action arguments are enabled, it can be
>>>>>>>> confusing and frustrating.
>>>>>>>
>>>>>>> testing: tier1-5
>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8236111
>>>>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/
>>>>>>>
>>>>>>> Thanks,
>>>>>>> -- Igor
