noreg-doc added. I thought about noreg-cleanup, but this is much safer than a normal cleanup.
--Max > On Mar 13, 2020, at 8:17 PM, Sean Mullan <[email protected]> wrote: > > One comment actually - you need to add a noreg label to the bug. > > --Sean > > On 3/13/20 8:13 AM, Sean Mullan wrote: >> Looks fine. >> --Sean >> On 3/13/20 5:44 AM, Weijun Wang wrote: >>> Please review the patch below. Unlike Sun, Oracle has no "Portions" >>> copyright notice for Third Party source file changes, just add the standard >>> Oracle copyright notice if a file has been modified. >>> >>> *diff --git >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java >>> >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java* >>> >>> *--- >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java* >>> >>> *+++ >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java* >>> >>> @@ -21,7 +21,7 @@ >>> * under the License. >>> */ >>> /* >>> - * Portions copyright (c) 2005, 2019, Oracle and/or its affiliates. All >>> rights reserved. >>> + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights >>> reserved. >>> */ >>> /* >>> * >>> =========================================================================== >>> *diff --git >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java >>> >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java* >>> >>> *--- >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java* >>> >>> *+++ >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java* >>> >>> @@ -21,7 +21,7 @@ >>> * under the License. >>> */ >>> /* >>> - * Portions copyright (c) 2005, 2019, Oracle and/or its affiliates. All >>> rights reserved. >>> + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights >>> reserved. >>> */ >>> /* >>> * >>> =========================================================================== >>> *diff --git >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java >>> >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java* >>> >>> *--- >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java* >>> >>> *+++ >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java* >>> >>> @@ -21,7 +21,7 @@ >>> * under the License. >>> */ >>> /* >>> - * Portions copyright (c) 2005, 2019, Oracle and/or its affiliates. All >>> rights reserved. >>> + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights >>> reserved. >>> */ >>> /* >>> * >>> =========================================================================== >>> *diff --git >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java >>> >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java* >>> >>> *--- >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java* >>> >>> *+++ >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java* >>> >>> @@ -28,7 +28,7 @@ >>> * >>> =========================================================================== >>> */ >>> /* >>> - * Portions copyright (c) 2005, 2019, Oracle and/or its affiliates. All >>> rights reserved. >>> + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights >>> reserved. >>> */ >>> /* >>> * $Id: DOMXPathFilter2Transform.java 1854026 2019-02-21 09:30:01Z >>> coheigea $ >>> *diff --git >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java >>> >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java* >>> >>> *--- >>> a/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java* >>> >>> *+++ >>> b/src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java* >>> >>> @@ -28,7 +28,7 @@ >>> * >>> =========================================================================== >>> */ >>> /* >>> - * Portions copyright (c) 2005, 2019, Oracle and/or its affiliates. All >>> rights reserved. >>> + * Copyright (c) 2005, 2019, Oracle and/or its affiliates. All rights >>> reserved. >>> */ >>> /* >>> * $Id: XMLDSigRI.java 1833618 2018-06-15 17:36:20Z mullan $ >>> >>> Thanks, >>> Max >>>
