Another question: Why does getAlgorithm() of PublicKey and PrivateKey return "EdDSA" instead of "Ed25519" and "Ed448"?
Do we suggest people using "EdDSA" or "Ed25519"/"Ed448" when calling KeyFactory.getInstance() and KeyPairGenerator.getInstance()? Thanks, Max > On Mar 24, 2020, at 2:53 AM, Anthony Scarpino <anthony.scarp...@oracle.com> > wrote: > > On 2/25/20 12:49 PM, Anthony Scarpino wrote: >> Hi >> I need a code review for the EdDSA support in JEP 339. The code builds on >> the existing java implemented constant time classes used for XDH and the >> NIST curves. The change also adds classes to the public API to support >> EdDSA operations. >> All information about the JEP is located at: >> JEP 339: https://bugs.openjdk.java.net/browse/JDK-8199231 >> CSR: https://bugs.openjdk.java.net/browse/JDK-8190219 >> webrev: https://cr.openjdk.java.net/~ascarpino/8166597/webrev/ >> thanks >> Tony > > > I updated the webrev with some minor updates that were commented previously. > > https://cr.openjdk.java.net/~ascarpino/8166597/webrev.01/ > > Tony
