Is OidString::toString really used anywhere? If so, I suggest we create a special method for it so it's easy to use an IDE to find out all usages. Finding toString returns usages of Object::toString and it's everywhere.
--Max > On Apr 24, 2020, at 7:11 AM, Valerie Peng <valerie.p...@oracle.com> wrote: > > Hi Max, > > Would you have time to review this change? The current webrev attempts to > cover all security classes where hard-coded oid strings and consolidate these > known oid string values into a single enum type. The changes are quite > extensive, I can trim back and only cover the provider algorithm oids if you > prefer. There are pros and cons for both approach. > > I know that the naming convention is to use all upper case for enum > constants, but choose to use the same naming convention as standard names to > simplify the code. SecurityProviderConstants class defines the common > mappings which are general to providers. Provider-specific alias mappings are > handled in specific provider class, e.g. SunJSSE class. > > RFE: https://bugs.openjdk.java.net/browse/JDK-8242151 > > Webrev: http://cr.openjdk.java.net/~valeriep/8242151/webrev.00/ > > Mach5 runs clean. > > Valerie >
