Found an existing test I can update. Webrev updated at http://cr.openjdk.java.net/~weijun/8244565/webrev.01/
Thanks, Max > On May 8, 2020, at 5:41 PM, Weijun Wang <weijun.w...@oracle.com> wrote: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8244565/webrev.00/ > > Now we accepts a PKCS8 file with version being 0 or 1. The publicKey and > attributes are still not parsed. > > I also take this chance to make some format change. > > There is no regression test and I'll add one. I can generate a PKCS8 key and > then modify the version from 0 to 1 and try to read it. Or I can find a PKCS8 > generated by some other tool and embed it the test to read it. Please advise > which is better. > > Thanks, > Max >