On 22/06/2020 10:00, Andrew Haley wrote: > On 18/06/2020 19:33, Martin Balao wrote:
snip... >> * L3724 >> * The last argument of 'sub' has type 'int', while in the not-Windows >> variant is a long. Can we align this? > > We should do that, yes. Better it be long everywhere. > Patch looks good to me too. Simon, if you are happy with changing the final argument of sub to long on the Windows side, I'll sponsor this patch, make that minor change and push: https://cr.openjdk.java.net/~stooke/webrevs/jdk-8243114-jdk/01/01/jdk.patch to jdk/jdk Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
signature.asc
Description: OpenPGP digital signature
