On Tue, 22 Sep 2020 15:17:23 GMT, Alexey Bakhtin <abakh...@openjdk.org> wrote:

>> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/TlsChannelBinding.java 
>> line 63:
>> 
>>> 61:          * Channel binding on the basis of TLS Finished message
>>> 62:          */
>>> 63:         TLS_UNIQUE("tls-unique"),
>> 
>> Is that still used? If not maybe it should be removed?
>
> No, It is not used.
> However, I'd like to leave it as is (it is mentioned in the documentation as 
> unsupported value).
> Otherwise, TlsChannelBindingType enum will have one element only and should 
> be simplified/removed in all places. In
> this case, it would be double work to add TlsChannelBindingType enum back in 
> the future if "tls-unique" required. If
> required I can remove TLS_UNIQUE item, but not remove TlsChannelBindingType 
> enum

OK

-------------

PR: https://git.openjdk.java.net/jdk/pull/278

Reply via email to