On Tue, 29 Sep 2020 19:40:46 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> > > > Regarding the end-of-content identifier, that looks good. Thanks for fixing > > the indentation for the right-side ASN.1 > > interpretation of the bytes. My only remaining question is whether the > > corresponding hex dumps on the left should match > > the indentation levels as well. I don't have a strong opinion either way on > > that one but if you're indenting for each > > element at the same nest level it seems like that could potentially chew up > > a lot of horizontal space. Was the extra > > indentation for the second octet string done for readability? > > Max had requested the current offset of the byte values, so it was easy to > see where each new value started and to keep > the offsets on a modulo boundary. The formatter on the right is largely > decoupled from the hex value tabular form on > the left while keeping the correspondence between the formatted items and the > bytes. If you and Max find that better from a visual perspective then that works for me. Thanks for clarifying that. ------------- PR: https://git.openjdk.java.net/jdk/pull/268
