On Wed, 7 Oct 2020 16:29:32 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Xuelei comments
>
> src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 947:
>
>> 945: // create temporary output buffer if the estimated size is
>> larger
>> 946: // than the user-provided buffer.
>> 947: if (output.length - outputOffset < estOutSize) {
>
> "outputCapacity" could be used to replace "output.length - outputOffset", and
> join the clause with the if-clause above.
interesting.. That makes this and the if condition below it able to join again.
> src/java.base/share/classes/com/sun/crypto/provider/CounterMode.java line 28:
>
>> 26: package com.sun.crypto.provider;
>> 27:
>> 28: import java.nio.ByteBuffer;
>
> There is no more update except this line. The new import ByteBuffer may not
> be used.
Thanks. That is another new thing to get used to with git and multiple
commits. When cleaning up code it's easy to
not see changes like this.
-------------
PR: https://git.openjdk.java.net/jdk/pull/411
