On Mon, 12 Oct 2020 15:35:12 GMT, Lance Andersen <lan...@openjdk.org> wrote:

>> Volker Simonis has refreshed the contents of this pull request, and previous 
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The 
>> pull request contains one new commit since
>> the last revision:
>>   8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's 
>> compressed size
>
> src/java.base/share/classes/java/util/jar/JarOutputStream.java line 81:
> 
>> 79:      * any previous entry. The default compression method will be
>> 80:      * used if no compression method was specified for the entry.
>> 81:      * When writing a compressed (i.e. {@code ZipEntry.DEFLATED}))
> 
> I would leave as DEFLATED given it is used this way in other ZipOutputStream 
> methods and I would also remove the  "i.e."

I would prefer to keep it as "When writing as compressed (DEFLATED) ..." to 
keep the terminology consistent when
linking to the setCompressedMethod.

-------------

PR: https://git.openjdk.java.net/jdk/pull/520

Reply via email to