On Fri, 20 Nov 2020 18:09:26 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Jamil Nimeh has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits since the last revision: >> >> - Update test to account for JDK-8202343 fix >> - Merge >> - Merge >> - Applied code review comments to tests >> - Fix cut/paste error with ECDH-RSA key exchange >> - Merge >> - Initial EdDSA/TLS solution > > src/java.base/share/classes/sun/security/ssl/JsseJce.java line 97: > >> 95: */ >> 96: static final String SIGNATURE_EDDSA = "EdDSA"; >> 97: > > Please update the copyright year. > > Is it possible that "ed25519" or "ed448" is used as the signature algorithm, > especially in the X.509 certificate implementation? SunEC's algorithm name for keys are always "EdDSA", but I know BC returns "Ed25519" or "Ed448". ------------- PR: https://git.openjdk.java.net/jdk/pull/1197
