On Wed, 25 Nov 2020 13:37:02 GMT, Rémi Forax
<github.com+828220+fo...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8248862: Implement Enhanced Pseudo-Random Number Generators
>>
>> Changes to RandomGeneratorFactory requested by @PaulSandoz
>
> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java line
> 88:
>
>> 86: * <pre>{@code
>> 87: * RandomGeneratorFactory<RandomGenerator> best =
>> RandomGenerator.all()
>> 88: * .sorted((f, g) -> Integer.compare(g.stateBits(),
>> f.stateBits()))
>
> use Comparator.comparingInt(RandomGenerator::stateBits) instead of the lambda
Not sure that
`.sorted(Comparator.comparingInt(RandomGeneratorFactory<RandomGenerator>::stateBits).reversed())`
is simpler than `.sorted((f, g) -> Integer.compare(g.stateBits(),
f.stateBits()))`.
> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java line
> 116:
>
>> 114: * Map of properties for provider.
>> 115: */
>> 116: private volatile Map<RandomGeneratorProperty, Object> properties =
>> null;
>
> `= null` is useless here
agree
-------------
PR: https://git.openjdk.java.net/jdk/pull/1292
