On Tue, 1 Dec 2020 22:42:54 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - test updates >> - test check mixup >> - Overlap protection >> - Updated code comments, all tests pass >> - Updated code comments, all tests pass > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 539: > >> 537: // Construct and encrypt a block if there is enough >> 'buffer' and >> 538: // 'in' to make one >> 539: if ((inLen + remainder) >= blockSize) { > > This big block of code is only needed when (remainder != 0), right? If there is nothing in the ibuffer, then it never gets here. Yes. btw, make sure you're looking at the right webrev, the line numbers didn't match up with revision 4. ------------- PR: https://git.openjdk.java.net/jdk/pull/411