On Thu, 18 Mar 2021 17:30:55 GMT, Ziyi Luo <luoz...@openjdk.org> wrote:
>> This is a P2 regression introduced by JDK-8254717. >> >> In `RSAKeyFactory.engineGetKeySpec`, when the key is a RSA key and the >> KeySpec is RSAPrivateKeySpec or RSAPrivateCrtKeySpec. The method behavior is >> described as follow: >> >> X-axis: type of `keySpec` >> Y-axis: type of `key` >> >> Before JDK-8254717: >> >> | | RSAPrivateKeySpec.class | RSAPrivateCrtKeySpec.class | >> |--|--|--| >> | RSAPrivateKey | Return RSAPrivateKeySpec | Throw >> `InvalidKeySpecException` | >> | RSAPrivateCrtKey | Return RSAPrivateKeySpec | Return RSAPrivateKeyCrtSpec | >> >> After JDK-8254717 (Green check is what we want to fix, red cross is the >> regression): >> >> | | RSAPrivateKeySpec.class | RSAPrivateCrtKeySpec.class | >> |--|--|--| >> | RSAPrivateKey | Throw `InvalidKeySpecException` ❌ | Throw >> `InvalidKeySpecException` | >> | RSAPrivateCrtKey | Return RSAPrivateKeyCrtSpec ✅ | Return >> RSAPrivateKeyCrtSpec | >> >> This commit fixes the regression. >> >> >> ### Tests >> >> * Jtreg: All tests under `java/security`, `sun/security`, `javax/crypto` >> passed >> * JCK: All JCK-16 (I do not have jCK-17)tests under `api/java_security` >> passed > > Ziyi Luo has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains four commits: > > - Fix P11RSAKeyFactory and add one more jtreg test > - Add one test case for the regression fixed by 8263404 > - Fix jcheck whitespace error > - 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in > RSAKeyFactory.engineGetKeySpec This looks to cover the cases and fixes we talked about. ------------- PR: https://git.openjdk.java.net/jdk/pull/2949
