On Tue, 23 Mar 2021 18:41:26 GMT, Greg Rubin <github.com+829871+salusasecon...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed AlgorithmParameters impls to register under AES/KW/NoPadding and >> AES/KWP/NoPadding > > src/java.base/share/classes/com/sun/crypto/provider/AESKeyWrap.java line 155: > >> 153: " be at least 16 bytes and multiples of 8"); >> 154: } >> 155: // assert ptOfs == 0; ct == pt; ctOfs == 0; > > Is this a missing code assertion? Hmm, there are some inconsistencies in how the variables are named. I will remove this comment and update the method javadoc accordingly, i.e. ptOfs, ct, ctOfs have all been renamed to dummyN. ------------- PR: https://git.openjdk.java.net/jdk/pull/2404
