On Wed, 31 Mar 2021 00:07:14 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Martin Balao has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Avoid overriding buffered bytes with padding in the doFinal call.
>> - Only do encryption block-size buffering for NSS
>> - 8261355: No data buffering in SunPKCS11 Cipher encryption when the
>> underlying mechanism has no padding
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java line
> 910:
>
>> 908: if (paddingObj != null) {
>> 909: int actualPadLen =
>> paddingObj.setPaddingBytes(padBuffer,
>> 910: 0, requiredOutLen - bytesBuffered);
>
> Shouldn't the starting offset be 'padBufferLen'?
Oh, yes, well spotted.. I forgot to synchronize with the byte[] path.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2510
