On Mon, 12 Apr 2021 13:23:44 GMT, Sean Mullan <mul...@openjdk.org> wrote:
> The `@implSpec` looks good. I view the `@implNote` more like an `@apiNote` > though. API notes are for "[commentary, rationale, or examples pertaining to the API](https://bugs.openjdk.java.net/browse/JDK-8068562)". I'm not sure if `getParameterSpec()` must always return a non-null object when algorithm is RSASSA-PSS. The spec says "may be <code>null</code> if not specified". So I used "In this implementation". > test/lib/jdk/test/lib/security/XMLUtils.java line 63: > >> 61: import java.security.spec.PSSParameterSpec; >> 62: import java.util.*; >> 63: > > Can you add some comments about this class, e.g., "A collection of test > utility methods for parsing, validating and generating XML Signatures". OK for this and the next two. ------------- PR: https://git.openjdk.java.net/jdk/pull/3181
