On Wed, 14 Apr 2021 17:17:03 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Please review the changes for the subject issue.  This has been suggested in 
>> a recent discussion thread for the JEP 400 
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>>  A CSR has also been drafted, and comments are welcome 
>> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Added @see links.

src/java.base/share/classes/java/io/Console.java line 397:

> 395:     /**
> 396:      * Returns the {@link java.nio.charset.Charset Charset} object used 
> in
> 397:      * the {@code Console}.

What would you think about re-phrasing the first sentence to use "for the 
Console" rather than "in the Console".

src/java.base/share/classes/java/lang/System.java line 123:

> 121:      *
> 122:      * @see Console#charset()
> 123:      * @see Console#reader()

What would you think about changing the example in InputStreamReader class 
description as part of this?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3419

Reply via email to