On Thu, 6 May 2021 01:23:40 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> better comment
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 811:
>
>> 809: byte[] salt = getSalt();
>> 810: if (KnownOIDs.findMatch(algorithm) ==
>> KnownOIDs.PBEWithMD5AndDES) {
>> 811: // PBEWithMD5AndDES requires a 8-byte salt
>
> nit: maybe use "PBES1 scheme such as PBEWithMD5AndDES requires a 8-byte salt"
Sure. Updated.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3822
