> Anyone can help review this somewhat trivial fix? The main change is inside > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to > help better troubleshooting by reporting the type of unavailable attributes > in PKCS11 exception message when C_GetAttributeValue(...) call failed. The > java file changes are just cleanup for consolidating the CKR_* constants > definition into PKCS11Exception class. > > Thanks, > Valerie
Valerie Peng has updated the pull request incrementally with one additional commit since the last revision: PKCS11Exception class refactoring - use enum instead of HashMap ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3709/files - new: https://git.openjdk.java.net/jdk/pull/3709/files/285196b4..c08f62f7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3709&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3709&range=01-02 Stats: 244 lines in 1 file changed: 117 ins; 102 del; 25 mod Patch: https://git.openjdk.java.net/jdk/pull/3709.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3709/head:pull/3709 PR: https://git.openjdk.java.net/jdk/pull/3709