On Mon, 17 May 2021 20:24:51 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Hi, >> >> I need a review of this rather large change to GCM. GCM will no longer use >> CipherCore, and AESCrypt to handle it's buffers and other objects. It is >> also a major code redesign limits the amount of data copies and make some >> performance-based decisions. >> >> Thanks >> >> Tony > > src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java line 155: > >> 153: super(32, new AESCrypt()); >> 154: } >> 155: } > > These should be removed since SunJCE registers > com.sun.crypto.provider.GaloisCounterMode$AES128/AES192/AES256 instead of > these? In addition, the private boolean field "updateCalled" of this class and its relevant assignments can also be removed. ------------- PR: https://git.openjdk.java.net/jdk/pull/4072
