On Mon, 24 May 2021 16:54:39 GMT, Anthony Scarpino <[email protected]>
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 338:
>>
>>> 336: public int doFinal(ByteBuffer src, ByteBuffer dst) {
>>> 337: return doFinal(src, src.remaining());
>>> 338: }
>>
>> Have you considered changing the argument list of existing
>> update/doFinal(...) methods? Less calls.
>
> I had considered it, but there are a number of methods, particularly in the
> in decrypt operation, where the non-interface methods are called. I didn't
> think it was right for all those calls to have "null" and "0" for output
> arguments they don't use.
> It's possible this interface may be not needed with a future Intel intrinsic,
> so we shall see.
Ok.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4072
