Thanks for the review Valerie. I've gone ahead and updated the test.
You've a good point in that the PKCS11Test framework didn't suit the
test that I needed. The new test no longer extends PKCS11Test as a
result. I have kept the refactoring in PKCS11Test thought since it can
offer up some useful helper static methods. I did clean up the
testNSS(..) static methods. You're right that the 2nd Provider parameter
was redundant. Removed that.
Changes pushed.
regards,
Sean.
On 12/05/2021 19:55, Valerie Peng wrote:
On Fri, 7 May 2021 13:51:05 GMT, Sean Coffey <[email protected]> wrote:
Added capability to allow the PKCS11 Token to be destroyed once a session is
logged out from. New configuration properties via pkcs11 config file. Cleaned
up the native resource poller also.
New unit test case to test behaviour. Some PKCS11 tests refactored to allow
pkcs11 provider to be configured (and tested) with a config file of choice.
Reviewer request @valeriepeng
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Initial corrections from RFR
The update changes look good. Will wait for your test edit then.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3544
