On Fri, 21 May 2021 00:05:17 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 1442:
>
>> 1440: throw new ShortBufferException("Output buffer too
>> small, must" +
>> 1441: "be at least " + (len - tagLenBytes) + " bytes
>> long");
>> 1442: }
>
> This looks like a half-baked save/restore functionality?
This one forgot to restore the saved object
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
> line 1475:
>
>> 1473:
>> 1474: // Length of the input
>> 1475: ByteBuffer tag;
>
> Is the comment obsolete? I don't quite follow how it's related to 'tag'.
sounds obsolete
-------------
PR: https://git.openjdk.java.net/jdk/pull/4072
