On Wed, 29 Sep 2021 18:13:14 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Follow-up change to JDK-8231262, augmentations to javac's Xlint:serial >> checking are out for review (#5709) and various security libraries would >> need some changes to pass under the expanded checks. >> >> The changes are to suppress warnings where non-transient fields in >> serializable types are not declared with a type statically known to be >> serializable. That isn't necessarily a correctness issues, but it does merit >> further scrutiny. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - Add explanatory comments for SuppressWarnings annotations. > - Merge branch 'master' into JDK-8274393 > - 8274393: Suppress more warnings on non-serializable non-transient instance > fields in security libs Looks fine. ------------- Marked as reviewed by weijun (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5720