On Tue, 2 Nov 2021 15:18:10 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clarification on protected attributes
>
> src/java.base/share/classes/java/security/KeyStore.java line 1030:
>
>> 1028: *
>> 1029: * @param alias the alias name
>> 1030: * @return an unmodifiable {@code Set} of attributes, possibly
>> empty
>
> If the alias does not exist, then is it definitely always empty? I think the
> word "possibly" here may be a bit misleading. Maybe reword this as:
> "an unmodifiable {@code Set} of attributes." This set is empty if the given
> alias does not exist or there are no attributes associated with the alias.
> This set may also be empty for PrivateKeyEntry or SecretKeyEntry entries that
> contain protected attributes and are only available through the ... "
Updated as suggested. CSR updated as well.
> src/java.base/share/classes/java/security/KeyStore.java line 1031:
>
>> 1029: * @param alias the alias name
>> 1030: * @return an unmodifiable {@code Set} of attributes, possibly
>> empty
>> 1031: * if the given alias does not exist, or there is no
>
> s/is no/are no/
Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6026
