On Wed, 3 Nov 2021 09:16:47 GMT, Daniel Jeliński <d...@openjdk.java.net> wrote:
>> The current code that changes cipher suites disposes the new suite instead >> of the old one, which usually silently fails. This patch fixes the code to >> dispose the old instance instead. >> >> DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and >> correctly [disposes the old >> one](https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.base/share/classes/sun/security/ssl/DTLSOutputRecord.java#L106), >> and DTLSInputRecord [doesn't dispose >> anything](https://github.com/openjdk/jdk/blob/4b9303b77b43d890ebacbec38b4ac5db7e171886/src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java#L57) > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > bugfix > > Please hold off on the integration, the regression testing failed. > > could you point me to the failing test? I'm running the jdk_security suite; > only sun/security/mscapi/ShortRSAKeyWithinTLS is failing, and it's failing > because of environmental reasons (Windows is asking for some PIN) > > _EDIT_ found them; started testing jdk_core and the tests surfaced pretty > quickly. I normally run tier1 and tier2 test. ------------- PR: https://git.openjdk.java.net/jdk/pull/6084
