On Sat, 6 Nov 2021 08:54:33 GMT, Daniel Jeliński <d...@openjdk.java.net> wrote:
>>> Hi @XueleiFan, >>> >>> Thank you for the feedback, though it’s not recommended to set the >>> protocols and cipher suites, various frameworks often do set these values, >>> [Some references below]. Would it still make sense to only optimize the >>> default case? >> >> I know, there are applications setting protocols and cipher suites for >> themselves. But it should be common that the TLS connections created from >> the same SSLContext uses the same cipher suites and protocols. There are >> still exceptions, but may be not that common. Using an instance cache in >> SSLContext rather than static cache could be a further improvement. >> >> I would not use static cache unless there is no other option. The >> troublesome of static cache is more than the performance impact. A series >> of problems like memory leaking and security issues could be followed even >> we design the cache very carefully. >> >> About the benchmark, did you have a chance to check the result for full >> handshakes? The code in the benchmark checks the initialization of the >> handshake, the handshake may not be full/completed. A benchmark for full >> handshake may be able to provide more evidence about the overall impact of >> the improvement. > > Can we extend the public API of `SSLContext` with methods for managing > `activeProtocols`, `activeCipherSuites` and possibly `algorithmConstraints`? > Without this API change we would need to check every time if the active > protocols, ciphers and constraints match the cached ones. > > Also, looking at the flame graphs provided, it appears that about 50% of the > handshake time is spent in `SSLAlgorithmDecomposer#decompose`; given that > there are only 3 instances of that class (and could be further reduced to 2), > would it make sense to optimize the method by caching the results of > algorithm decomposition? We could use a size-limited soft cache to avoid > memory leaks, and I fail to see how the cached information could be > exploitable. > Hi @djelinski @XueleiFan, > > Thank you for the feedback on this issue. > > `activeProtocols` and `activeCipherSuites` are currently derived from > `enabledProtocols` and `enabledCipherSuites` and `algorithmConstraints`. And > the [SSLContext is currently considered as > immutable.](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java#L42). > If we provide ways to configure in SSLContext, We would need to rewrite this > assumption. That could have implications in other areas where this assumption > is currently held(?). I don't think it is the direction to change the immunity of SSLContext. There are two proposals right now. One is to change the SSLContext public APIs, @djelinski, by adding cipher suites and protocols configuration (immutable). This proposal does not impact the current code, where enabled protocols and cipher suites are configured in each socket. But it could be useful for future code to configure these parameters in the context level. It may be easier to maintain and could have better performance. I did not have time to think over the potentials yet, but I did have the proposal to move from static cache to instance cache. SSLContext/impl is ideal because normally only one SSLContext instance is required, surely there are exceptions, for an application. We may also missed another issue that the underlying crypto provider could change, for example unplugging a token from the slot. Once the crypto provider is changed, the cached binding between protocol and cipher suites may not work any longer. So we may need to take care of this kind of issue for static cache. For an instance of SSLContext, the crypto provider changing issues are still there, but get mitigated as the context has already bound to specific trust manager and key manager. Yes, it does change the SSLContext implementation from immutability to mutability. But it is in an acceptable level, just as what we did for session cache in the context instance. Just for your consideration. This is a tough problem, and it may take time to find a suitable solution. Let's keep exchanging our thoughts about it. > > The other option of having an instance cache in SSLContext could be helpful > as well, but then it would also affect the assumption above. > > I can look into optimizing the SSLAlgorithmDecomposer, by adding a size > limited cache there to see if it would beneficial. This could be an instance > variable as well, so @XueleiFan concerns of static cache can also be > addressed. I'll check if the benchmarks look better with the new approach. > > Additionally, I looked into the decompose method and found that there is > scope for improvements there. We could eliminate the [repeated calls to > decompose > CipherSuite](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/ssl/SSLAlgorithmDecomposer.java#L269). > This would need us to store the results of decomposing the CipherSuite, Both > in the case of when onlyX509 is true and false. > > Other optimization in the decompose path are in SSLCipher, but this won't be > necessary if we optimize the CipherSuite decompose mentioned above. > > Other times spent in the function is within the HashMap and Collections > (`add` and `addAll`). > > <img alt="Screen Shot 2021-11-09 at 1 29 57 PM" width="2000" > src="https://user-images.githubusercontent.com/934461/141008035-a6549701-2233-4d3e-ba61-7859d25b339c.png";> > > I can follow up on this based on the results of the SSLAlgorithmDecomposer > optimizations, and if this is still an issue, I can open a seperate JBS issue > and create a PR for this. Yes, please. Your found is impressive to me. ------------- PR: https://git.openjdk.java.net/jdk/pull/5793
![https://user-images.githubusercontent.com/934461/141008035-a6549701-2233-4d3e-ba61-7859d25b339c.png"](https://user-images.githubusercontent.com/934461/141008035-a6549701-2233-4d3e-ba61-7859d25b339c.png"){kind=link}