On Mon, 7 Feb 2022 19:59:32 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct null tags
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 47:
>
>> 45: * <p>
>> 46: * SSLParameters can be created via the constructors in this class.
>> 47: * Objects can also be obtained using the {@code getSSLParameters()}
>
> Since you introduce the terms "pre-populated" and "connection populated" in
> the new methods, I think it would be useful to describe them up front in the
> summary, ex:
>
> `{@code SSLParameter} objects can be created via the constructors in this
> class, and can be described as pre-populated objects. {@code SSLParameter}
> objects can also be obtained using the ... <list all the methods>, and can be
> described as connection populated objects."
Nice! It is something I want to add for quite a while, but never get a chance.
The suggested description is really simple and great!
Updated!
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 747:
>
>> 745: *
>> 746: * @return an array of signature scheme {@code Strings} or {@code
>> null} if
>> 747: * none have been set. For non-null returns, this method
>> willu
>
> Typo, s/willu/will/
Thanks!
-------------
PR: https://git.openjdk.java.net/jdk/pull/7252
