Re: RFR: 8277976: Break up SEQUENCE in X509Certificate::getSubjectAlternativeNames and X509Certificate::getIssuerAlternativeNames in otherName [v4]

[Michael Osipov]

On Fri, 11 Feb 2022 17:13:46 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> The enhancement adds two extra items in the `getSubjectAlternativeNames()` 
>> output for an OtherName.
>> 
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` 
>> without the tag and length bytes.
>> 2. The argument in constructor `extClass.getConstructor(Object.class)` is 
>> suspicious. Maybe it meant `byte[]`.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   specifies the type of the 4th element

src/java.base/share/classes/sun/security/x509/OtherName.java line 93:

> 91:         oid = in.getOID();
> 92:         DerValue derValue1 = in.getDerValue();
> 93:         if (!derValue1.isContextSpecific((byte)0)) {

Where do you check for constructed (0x20)?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7167