On Tue, 12 Apr 2022 21:59:09 GMT, Mark Powers <d...@openjdk.java.net> wrote:
> JDK-8284112 Minor cleanup could be done in javax.crypto src/java.base/share/classes/javax/crypto/ExemptionMechanism.java line 142: > 140: * @see java.security.Provider > 141: */ > 142: public static ExemptionMechanism getInstance(String algorithm) Others might disagree with this comment, but I would encourage you not to make these changes throughout your PR. (@jddarcy ?) Even though a static method is implicitly final and IJ is correct, the final keyword does prevent subclasses from inadvertently using the same method signature. ------------- PR: https://git.openjdk.java.net/jdk/pull/8214