On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> I ran `codespell` on the `src/java.base` directory, and accepted those 
> changes where it indeed discovered real typos.
> 
> (Due to false positives this can unfortunately not be run automatically) 
> 
> The majority of fixes are in comments. A handful is in strings, one in a 
> local variable name, and a couple in parameter declarations.
> 
> Annoyingly, there are several instances of "childs" (instead of "children") 
> in the source code, but they were not local and I dared not change them. 
> Someone braver than me might take a stab at it, perhaps..

src/java.base/share/classes/jdk/internal/icu/impl/NormalizerImpl.java line 2002:

> 2000:                 }
> 2001: 
> 2002:                 // this is where we are right now with all these 
> indices:

Although these are actual typos, they come from upstream ICU code. Changing 
them locally would make merging complicated, so please exclude ICU related 
changes from the PR. I guess fixes in other 3rd party libraries are in the same 
boat.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8250

Reply via email to