On Thu, 28 Apr 2022 02:33:49 GMT, Mark Powers <d...@openjdk.java.net> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504 >> >> JDK-8273046 is the umbrella bug for this bug. The changes were too large for >> a single code review, so it was decided to split into smaller chunks. This >> is one such chunk: >> >> open/src/java.base/share/classes/java/net > > Mark Powers has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains eight additional > commits since the last revision: > > - Merge > - Max and Brad comments > - jaikiran comments > - Alan Bateman comments > - second iteration > - Merge > - Merge > - first iteration I made some wrong suggestions earlier. src/java.base/share/classes/javax/net/ssl/KeyManagerFactory.java line 70: > 68: String type; > 69: type = GetPropertyAction.privilegedGetProperty( > 70: "ssl.KeyManagerFactory.algorithm"); So sorry I got it wrong here, this is a security property. `GetPropertyAction.privilegedGetProperty` is for system properties. src/java.base/share/classes/javax/net/ssl/SSLSocketFactory.java line 92: > 90: static String getSecurityProperty(final String name) { > 91: return AccessController.doPrivileged((PrivilegedAction<String>) > () -> { > 92: return Security.getProperty(name); I assume we still need to do the if-empty-then-null conversion? src/java.base/share/classes/javax/net/ssl/TrustManagerFactory.java line 82: > 80: String type; > 81: type = GetPropertyAction.privilegedGetProperty( > 82: "ssl.TrustManagerFactory.algorithm"); Sorry I got it wrong here, this is a security property. ------------- PR: https://git.openjdk.java.net/jdk/pull/8384
