On Mon, 2 May 2022 16:46:17 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment about remove finalize() method > > src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java line 44: > >> 42: * overridden in SSLSocketImpl. >> 43: * >> 44: * There used to be a finalize() implementation, but decided that was > > Since you haven't pushed yet, maybe: > > There used to be a finalize() implementation that sent close_notify's, > but decided that was not needed. Not closing properly is more properly an > error condition that should be avoided. Applications should close sockets > and not rely on garbage collection. > > The underlying native resources are handled by the Socket Cleaner. Thanks for the rewording. Updated. ------------- PR: https://git.openjdk.java.net/jdk/pull/8065
