On Wed, 4 May 2022 20:32:30 GMT, Mat Carter <d...@openjdk.java.net> wrote:

>> On Windows you can now access the local machine keystores using the strings 
>> "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the 
>> application requires admin privileges.
>> 
>> "Windows-MY" and "Windows-ROOT" remain unchanged, however given these 
>> original keystore strings mapped to the current user, I added 
>> "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer 
>> can explicitly specify the current user location. These two new strings 
>> simply map to the original two strings, i.e. no duplication of code paths etc
>> 
>> No new tests added, keystore functionality and API remains unchanged, the 
>> local machine keystore types would require the tests to run in admin mode
>> 
>> Tested on windows, passes tier1 and tier2 tests
>
> Mat Carter has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Removed whitespace and simply passing ints between java and C++

Oops, I didn't realized that. Yes, you can divide it to 2 tests. The one needs 
admin privilege can be tagged `@run main/manual Test`. It probably won't get a 
lot of chance to run.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8211

Reply via email to